-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63424/#review189827
-----------------------------------------------------------



Your description here is not in-line with the comments in jira. Jira states 
that intent of your change is to be in-line with the hive char set. Doing so it 
would solve another issue you may see. Please confirm.

- kalyan kumar kalvagadda


On Oct. 30, 2017, 6:34 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63424/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 6:34 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio 
> Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> AUTHZ_OBJ_NAME has (384) chars. If its table char set is utf8, the constrain 
> AUTHZOBJNAME will have error "Specified key was too long; max key length is 
> 767 bytes"
> The solution is to specify the char set for this field, so it works for mysql 
> regardless the char set of its table or DB.
> 
> 
> Diffs
> -----
> 
>   
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql
>  a7db1b7 
>   
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql 
> 9f61154 
> 
> 
> Diff: https://reviews.apache.org/r/63424/diff/1/
> 
> 
> Testing
> -------
> 
> tested on system
> 
> 
> Thanks,
> 
> Na Li
> 
>

Reply via email to