----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/#review190334 -----------------------------------------------------------
Let's not commit this yet until we understand why AUTHZ_OBJ_NAME is Binary and if it can be set to a simple varchar() with CHARACTER SET utf8. Would this work? If it doesn't, then should we be consistent with Hive and set CHARACTER SET latin1 to all the varchar() columns? - Sergio Pena On Nov. 1, 2017, 7:32 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63424/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2017, 7:32 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio > Pena. > > > Repository: sentry > > > Description > ------- > > AUTHZ_OBJ_NAME has (384) chars. It is defieved from DB_NAME and TBL_NAME from > hive. hive is using latin1 char set for those fields. To be consistent with > hive, specify this field in sentry to latin1. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql > a7db1b7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql > 9f61154 > > > Diff: https://reviews.apache.org/r/63424/diff/1/ > > > Testing > ------- > > tested on system > > > Thanks, > > Na Li > >
