----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63335/ -----------------------------------------------------------
Review request for sentry and Sergio Pena. Bugs: SENTRY-2018 https://issues.apache.org/jira/browse/SENTRY-2018 Repository: sentry Description ------- SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase classes are obsolete now and can be removed. With this removed, there is no need to have enableNotificationLog flag it is the only way to events from HMS. Diffs ----- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java 11b6b4a sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListenerBase.java 40cf17a sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 33c9124 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 630bc68 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerInBuiltDeserializer.java 6ab3391 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java f33b2f3 Diff: https://reviews.apache.org/r/63335/diff/1/ Testing ------- Made sure the unit tests pass except solr test org.apache.solr.update.processor. Thanks, kalyan kumar kalvagadda