----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63335/#review190624 -----------------------------------------------------------
Ship it! Ship It! - Sergio Pena On Nov. 9, 2017, 2:58 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63335/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2017, 2:58 p.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Bugs: SENTRY-2018 > https://issues.apache.org/jira/browse/SENTRY-2018 > > > Repository: sentry > > > Description > ------- > > SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase > classes are obsolete now and can be removed. With this removed, there is no > need to have enableNotificationLog flag it is the only way to events from HMS. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 630bc689510b157ace404608bd854790294342c4 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerInBuiltDeserializer.java > 6ab3391159db82d03ffaba49abb23679af7e8b1d > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java > f33b2f3d981abd867eb0220a8d88994367b79696 > > > Diff: https://reviews.apache.org/r/63335/diff/2/ > > > Testing > ------- > > Made sure the unit tests passed. > > > Thanks, > > kalyan kumar kalvagadda > >
