-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63518/
-----------------------------------------------------------

Review request for sentry.


Bugs: SENTRY-1997
    https://issues.apache.org/jira/browse/SENTRY-1997


Repository: sentry


Description
-------

Here is a patch for this issue, which includes the update as well as switching 
the tests to use the new Jetty Server instead of Tomcat. It was quite tricky to 
resolve, I had to work around 2 issues in Sqoop which I have submitted patches 
for:

https://issues.apache.org/jira/browse/SQOOP-3250
https://issues.apache.org/jira/browse/SQOOP-3251


Diffs
-----

  pom.xml af544809 
  sentry-tests/sentry-tests-sqoop/pom.xml 6723c4d0 
  
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/AbstractSqoopSentryTestBase.java
 2971bf8c 
  
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/JettySqoopRunner.java
 PRE-CREATION 
  
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestConnectorEndToEnd.java
 27f14209 
  
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestGrantPrivilege.java
 8c7753ed 
  
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestJobEndToEnd.java
 636e2697 
  
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestLinkEndToEnd.java
 8c8a91dd 
  
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestOwnerPrivilege.java
 abef80c5 
  
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestRevokePrivilege.java
 f71595c0 
  
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestServerScopeEndToEnd.java
 85bae92b 
  
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestShowPrivilege.java
 0ccbf5d3 
  
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TomcatSqoopRunner.java
 0f0496bc 


Diff: https://reviews.apache.org/r/63518/diff/1/


Testing
-------

Tested successfully with a deployment as well.


Thanks,

Colm O hEigeartaigh

Reply via email to