----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/#review190512 -----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java Line 87 (original), 87 (patched) <https://reviews.apache.org/r/63687/#comment267962> Please add javaDoc explaining that this is case-insensitive comparison. Should both key and value be case-insensitive? Would it make sense to instead convert key and value to the canonical case in constructor? - Alexander Kolbasov On Nov. 8, 2017, 11:43 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63687/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2017, 11:43 p.m.) > > > Review request for sentry. > > > Bugs: sentry-2039 > https://issues.apache.org/jira/browse/sentry-2039 > > > Repository: sentry > > > Description > ------- > > Return the equalsIgnoreCase() to the KeyValue.equals() method (removed by > SENTRY-999) > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java > 4e944e5f2605459ac4166a784bb1d50362509221 > > sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java > ca44a245dc9abf003eaae13d0ebbfb1ef7eff29a > > sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java > 3f60b1901976d2236db0814fd63114c9598e8215 > > > Diff: https://reviews.apache.org/r/63687/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
