-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63687/
-----------------------------------------------------------
(Updated Nov. 13, 2017, 5:12 p.m.)
Review request for sentry.
Changes
-------
Back to the .4 patch that uses equalIgnoreCase() instead of lowering the case
in the constructor. My concern with the .5 patch is that by lowering the case
on the KeyValue constructor could rename policy content to be lower case, such
as policy files. However, this concern can be aliviated by digging deeper into
how the KeyValue is used, but I'll put this in follow-up jira. There is still
some concerns about the design of the KeyValue classs, os better to investigate
deeper there.
Bugs: sentry-2039
https://issues.apache.org/jira/browse/sentry-2039
Repository: sentry
Description
-------
Return the equalsIgnoreCase() to the KeyValue.equals() method (removed by
SENTRY-999)
Diffs (updated)
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
4e944e5f2605459ac4166a784bb1d50362509221
sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java
ca44a245dc9abf003eaae13d0ebbfb1ef7eff29a
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
3f60b1901976d2236db0814fd63114c9598e8215
Diff: https://reviews.apache.org/r/63687/diff/5/
Changes: https://reviews.apache.org/r/63687/diff/4-5/
Testing
-------
Thanks,
Sergio Pena
