> On Nov. 9, 2017, 2:56 p.m., kalyan kumar kalvagadda wrote:
> > What is the issue we are observing when this id is not set?

When timeout exception occurs, id is not set. This is a mandatory field, so 
Thrift creates its own exception which replaces the original timeout exception. 
As a result, client gets the wrong exception information back.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63647/#review190589
-----------------------------------------------------------


On Nov. 7, 2017, 9:58 p.m., Alexander Kolbasov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63647/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 9:58 p.m.)
> 
> 
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, and 
> Sergio Pena.
> 
> 
> Bugs: SENTRY-2036
>     https://issues.apache.org/jira/browse/SENTRY-2036
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors
> 
> 
> Diffs
> -----
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java
>  71eb9c1b6d02326fc9a7b702652253bd9b57d725 
> 
> 
> Diff: https://reviews.apache.org/r/63647/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Reply via email to