> On Nov. 9, 2017, 5:27 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1164 (patched) > > <https://reviews.apache.org/r/63647/diff/1/?file=1884192#file1884192line1164> > > > > Can we set the ID to be request.getId() instead of 0? So the value and > > the error message is consistent. Same thing for line 1170
I am not sure this would be correct since this ID wasn't processed yet. To some extend it doesn't matter because ID shouldn't be used by clients in case of errors. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/#review190613 ----------------------------------------------------------- On Nov. 7, 2017, 9:58 p.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63647/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 9:58 p.m.) > > > Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, and > Sergio Pena. > > > Bugs: SENTRY-2036 > https://issues.apache.org/jira/browse/SENTRY-2036 > > > Repository: sentry > > > Description > ------- > > SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 71eb9c1b6d02326fc9a7b702652253bd9b57d725 > > > Diff: https://reviews.apache.org/r/63647/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
