> On Nov. 10, 2017, 10:35 a.m., Colm O hEigeartaigh wrote:
> > Minor issues:
> >
> > a) Make sure there is a space before an opening bracket, e.g.:
> >
> > SentryShellGeneric: protected String getServiceNameGeneric(Configuration
> > conf){
> >
> > protected String getServiceName(Configuration conf){
> >
> > b) Spurious ";":
> >
> > AbstractAuthorizableFactory line 65: ;
> >
> > c) 2 spaces:
> >
> > KafkaModelAuthorizables: return
> > KafkaAuthorizable.AuthorizableType.values();
> >
> > Major issue:
> >
> > When I try to add a privilege to a role using the script I get a NPE:
> >
> > ./sentryShell -conf ../sentry-site.xml -gpr -r sqoop_test_role -p
> > "Server=sqoopServer1->Connector=c2->action=*" -t sqoop
> > java.lang.NullPointerException
> > at
> > org.apache.sentry.core.model.sqoop.SqoopModelAuthorizables.create(SqoopModelAuthorizables.java:31)
> >
> > Reading the privileges seems to work fine.
Thank you for the review! Yes, the tests failed as well (fortunatelly). I fix
the logic to follow the old one and uploaded new fix. Other issues are cleaned
as well.
- Mano
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63415/#review190689
-----------------------------------------------------------
On Nov. 16, 2017, 5:27 p.m., Mano Kovacs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63415/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2017, 5:27 p.m.)
>
>
> Review request for sentry and Colm O hEigeartaigh.
>
>
> Bugs: SENTRY-2012
> https://issues.apache.org/jira/browse/SENTRY-2012
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The patch makes SentryShellGeneric and GenericPrivilegeConverter independent
> of any component.
>
>
> Diffs
> -----
>
> bin/sentryShell 17b1429f096bc70c2dead8dbf708fd039baf319d
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AbstractAuthorizableFactory.java
> PRE-CREATION
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizableFactory.java
> PRE-CREATION
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizableType.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaAuthorizable.java
> 52ae614b7f44fc351406f5b4ca6d2a631b8ec750
>
> sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaModelAuthorizables.java
> 45a1148533ec4eb0f506b2dc6c81df6cc1663870
>
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizable.java
> 5a55963d40a9ad959660cf5381d3c2c6269ab0db
>
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizables.java
> 2b190e5ca2b49ca5737a9835e4b301317138ac21
>
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java
> 934875efbeff9ee66575e6e2a71c069da6e56cc4
>
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopModelAuthorizables.java
> 3bb9a19a36f297c8f6c94c0f6d112873ba2e32fb
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
> 51d6df958aea7681c62a751f25e3d2d624dc96dd
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryConfigToolSolr.java
> 77d39194f548dad8700d6f6ef6330c2fa0b92579
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellGeneric.java
> 49f18c8994df27217592fafc04ca3b96eaa4a978
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSolr.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSqoop.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryConfigToolSolr.java
> 3685073910e4b5f45183742723c6146749a927f1
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java
> 80bbcf184084a0a558351f2872ca0bb922c81aa3
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java
> 55831a45b4e75fefecbebd8ce13da73ce3697d4f
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSqoop.java
> 7bafd8c40c0c0be2b91fac4932bdb15709a379fd
>
>
> Diff: https://reviews.apache.org/r/63415/diff/4/
>
>
> Testing
> -------
>
> Unit-tests
>
>
> Thanks,
>
> Mano Kovacs
>
>
