----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63415/#review191314 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Nov. 16, 2017, 6:40 p.m., Mano Kovacs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63415/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2017, 6:40 p.m.) > > > Review request for sentry and Colm O hEigeartaigh. > > > Bugs: SENTRY-2012 > https://issues.apache.org/jira/browse/SENTRY-2012 > > > Repository: sentry > > > Description > ------- > > The patch makes SentryShellGeneric and GenericPrivilegeConverter independent > of any component. > > > Diffs > ----- > > bin/sentryShell 17b1429f096bc70c2dead8dbf708fd039baf319d > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AbstractAuthorizableFactory.java > PRE-CREATION > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizableFactory.java > PRE-CREATION > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizableType.java > PRE-CREATION > > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaAuthorizable.java > 52ae614b7f44fc351406f5b4ca6d2a631b8ec750 > > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaModelAuthorizables.java > 45a1148533ec4eb0f506b2dc6c81df6cc1663870 > > sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/SolrModelAuthorizable.java > 56cb4c220e5cc08834fe4b94c9d7102bc8d0d48e > > sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/SolrModelAuthorizables.java > 7979b3374fb2c5dbb18774dc3b071123dfd6f532 > > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java > 934875efbeff9ee66575e6e2a71c069da6e56cc4 > > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopModelAuthorizables.java > 3bb9a19a36f297c8f6c94c0f6d112873ba2e32fb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java > c65b66d0103cce329c3f84ad51119bf096cdd503 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryConfigToolSolr.java > 5649f43fa8366e1a13a250e09929d48e2ccf87f2 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellGeneric.java > 1623f3869b13f7f34909b5c9e3d58ff3e9b0d942 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSolr.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSqoop.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryConfigToolSolr.java > 9e6ff4212bea8ca2c15f4f11b792a12c642ea287 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java > a9234fa8e909339fc7b007622f48b5d20ef4c010 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java > 0f4bb62e7974f39e34b5faada78e388d7a34da04 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSqoop.java > cdba442002f7c5337b7070cb3c12c87129fe91d5 > > > Diff: https://reviews.apache.org/r/63415/diff/5/ > > > Testing > ------- > > Unit-tests > > > Thanks, > > Mano Kovacs > >
