> On Nov. 30, 2017, 11:07 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 346 (patched) > > <https://reviews.apache.org/r/63881/diff/6/?file=1905029#file1905029line346> > > > > Is getting empty snapshot while creating full snapshot normal? If not, > > perhaps info() or warn() would be better? Also, would not hurt including > > snapshotInfo.getId() into the log.
So it is usually the first case to hit, or the first cause of a full snap shot. So yes the chances of hitting this is high. The reason why it is debug is, as Sergio suggested, that if Sentry service is started, and no "work" is being done on HMS, we will always trigger creating a full snapshot. Only snapshot will be empty, so we will continue to trigger it. In which case this would be logged every 0.5 sec - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review192387 ----------------------------------------------------------- On Nov. 30, 2017, 10:41 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63881/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2017, 10:41 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and > Vadim Spector. > > > Repository: sentry > > > Description > ------- > > Currently we only seem to log when all conditions that lead to getting a > snapshot are validated, and eventually a full snapshot is received. However, > if for some reason a particular condition was invalid we don't log as to why. > This leaves no room for knowing definitely what might have been the reason as > to why a snapshot was not received from HMS. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > f32a745ed > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > c1471d118 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java > eccb40fb6 > > > Diff: https://reviews.apache.org/r/63881/diff/6/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test > > > Thanks, > > Arjun Mishra > >
