----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ -----------------------------------------------------------
(Updated Nov. 29, 2017, 5:24 p.m.) Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vadim Spector. Changes ------- Update based on Sergio's feedback Repository: sentry Description ------- Currently we only seem to log when all conditions that lead to getting a snapshot are validated, and eventually a full snapshot is received. However, if for some reason a particular condition was invalid we don't log as to why. This leaves no room for knowing definitely what might have been the reason as to why a snapshot was not received from HMS. Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java f32a745ed sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java c1471d118 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java eccb40fb6 Diff: https://reviews.apache.org/r/63881/diff/3/ Changes: https://reviews.apache.org/r/63881/diff/2-3/ Testing ------- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra
