----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/#review193563 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java Lines 222 (patched) <https://reviews.apache.org/r/64545/#comment272126> Instead of "becoming deactive", how about "No longer the leader in Sentry HA cluster." sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java Line 253 (original), 254 (patched) <https://reviews.apache.org/r/64545/#comment272124> "LeaderStatusMonitor" is extra. The log message should already contain the class name. "becoming active" is not clear. How about "becoming leader in Sentry HA cluster"? - Na Li On Dec. 12, 2017, 4:08 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64545/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2017, 4:08 p.m.) > > > Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, > Sergio Pena, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > Currently sentry's log messaging when it becomes a 'writer' (the sentry > server that reads from HMS) is not obvious, and is really mostly discernable > at the debug level. Add a log message at the INFO level, such as 'This sentry > server has just become the HMS reader/writer' that is printed once when the > sentry server first becomes the HMS reader/writer. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java > 360c5a530 > > > Diff: https://reviews.apache.org/r/64545/diff/2/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test > > > Thanks, > > Arjun Mishra > >
