> On Dec. 12, 2017, 7:01 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java > > Line 254 (original), 255 (patched) > > <https://reviews.apache.org/r/64545/diff/3/?file=1914583#file1914583line258> > > > > IncarnationId isn't very useful here > > Arjun Mishra wrote: > Incarnation Id returns hostname and pid. So having it here is useful > since it will tell us which specific Sentry service is now a leader. Let me > know if I am wrong please
1) You know the hostname and pid. 2) It is printed initially 3) The fact that it is hostname and pid is an internal detail of implementation. It could be any unique string. It could be useful for low-level Zookeeper debugging - that why I printed it when LeaderStatusMonitor starts, but it isn't generally useful. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/#review193589 ----------------------------------------------------------- On Dec. 13, 2017, 5:45 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64545/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2017, 5:45 p.m.) > > > Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, > Sergio Pena, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > Currently sentry's log messaging when it becomes a 'writer' (the sentry > server that reads from HMS) is not obvious, and is really mostly discernable > at the debug level. Add a log message at the INFO level, such as 'This sentry > server has just become the HMS reader/writer' that is printed once when the > sentry server first becomes the HMS reader/writer. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java > 360c5a530 > > > Diff: https://reviews.apache.org/r/64545/diff/6/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test > > > Thanks, > > Arjun Mishra > >
