> On Dec. 13, 2017, 6:42 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java > > Line 281 (original), 282 (patched) > > <https://reviews.apache.org/r/64545/diff/5-6/?file=1915545#file1915545line282> > > > > Note that in single node mode none of these are relevant since it is > > always a leader. > > Arjun Mishra wrote: > In that case it would print the defaults. "isSingleNodeMode=true, > incarnationId="", isLeader=true, leaderCount=0". I don't think that's > misleading. > > Alexander Kolbasov wrote: > Wouldn't it be more useful to print some kind of special status string in > this case? Something like "Leader election disabled" or whatever you think is > useful?
One last try :) With toString I would think we print class attribute values. "Leader election protocol disabled, assuming single active server" is printed in the constructor. - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/#review193716 ----------------------------------------------------------- On Dec. 13, 2017, 5:45 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64545/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2017, 5:45 p.m.) > > > Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, > Sergio Pena, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > Currently sentry's log messaging when it becomes a 'writer' (the sentry > server that reads from HMS) is not obvious, and is really mostly discernable > at the debug level. Add a log message at the INFO level, such as 'This sentry > server has just become the HMS reader/writer' that is printed once when the > sentry server first becomes the HMS reader/writer. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java > 360c5a530 > > > Diff: https://reviews.apache.org/r/64545/diff/6/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test > > > Thanks, > > Arjun Mishra > >