> On Dec. 18, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 267 (original), 271 (patched) > > <https://reviews.apache.org/r/64661/diff/3/?file=1922322#file1922322line271> > > > > I think there is a way to directly test for membership in the JDOQL - > > can you check this? > > > > We have similar code in SentryStore which does that.
Sasha not sure what exactly you are asking for? Are you asking for cases when a role is not mapped to any group? Also are your comments specific to my change? I did look at SentryStore. There are many places in the class where we addRolesFilter and run executeWithMap but I didn't see any check for membership being done here. - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review194080 ----------------------------------------------------------- On Dec. 18, 2017, 4:36 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64661/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2017, 4:36 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar > kalvagadda, Na Li, Sergio Pena, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > When Solr is using Sentry server for authorization, it issues a lot of calls > to {{getGroupsByRoles()}} function in {{DelegateSentryStore}}. > > This function isn't very efficient - it walks over each role in the set, > obtains role by name, get groups for each role, and collects all group names > into a set. > > It may be possible to optimize it. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > 4cb46abc5 > > > Diff: https://reviews.apache.org/r/64661/diff/3/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test > > > Thanks, > > Arjun Mishra > >
