> On Dec. 19, 2017, 9:22 p.m., Steve Moist wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 263 (patched) > > <https://reviews.apache.org/r/64661/diff/4/?file=1924031#file1924031line263> > > > > Any reason why this is needed when this method returns a list of > > strings and not the actual objects? > > Arjun Mishra wrote: > The query execution returns a list of objects. Then it is converted to a > set of strings.
List<MSentryGroup> mGroups = (List<MSentryGroup>)query.executeWithMap(paramBuilder.getArguments()) Detach on Commit to FALSE is for the above - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review194180 ----------------------------------------------------------- On Dec. 19, 2017, 8:04 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64661/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2017, 8:04 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar > kalvagadda, Na Li, Sergio Pena, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > When Solr is using Sentry server for authorization, it issues a lot of calls > to {{getGroupsByRoles()}} function in {{DelegateSentryStore}}. > > This function isn't very efficient - it walks over each role in the set, > obtains role by name, get groups for each role, and collects all group names > into a set. > > It may be possible to optimize it. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > 4cb46abc5 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java > 69d16238f > > > Diff: https://reviews.apache.org/r/64661/diff/4/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test > > > Thanks, > > Arjun Mishra > >
