> On Feb. 18, 2018, 5:29 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Line 96 (original), 96 (patched) > > <https://reviews.apache.org/r/65704/diff/1/?file=1962380#file1962380line96> > > > > This is Ok, but probably an overkill - we only need to sync table > > renames, so you may check that thist ALTER TABLE actually renames table (or > > database) and only sync in these cases.
For adding column, should we wait as well since privilege can be on column? If we only wait for rename, we still have issues - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review197721 ----------------------------------------------------------- On Feb. 18, 2018, 5:25 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65704/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2018, 5:25 a.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > wait for HMS sync at alter table, which including table rename and changing > table columns > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > 24d7763 > > > Diff: https://reviews.apache.org/r/65704/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
