> On May 17, 2018, 10:22 p.m., Sergio Pena wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
> > Lines 4336 (patched)
> > <https://reviews.apache.org/r/67174/diff/2/?file=2024614#file2024614line4347>
> >
> > noSuchRole() and noSuchGroup() exception messages are similar, can we
> > do the same thing for noSuchUser()?
This is exactly what you are asking for
private static SentryNoSuchObjectException noSuchUser(String userName) {
return new SentryNoSuchObjectException("nonexistent user " + userName);
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67174/#review203371
-----------------------------------------------------------
On May 18, 2018, 3:27 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67174/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 3:27 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar
> kalvagadda, and Sergio Pena.
>
>
> Bugs: sentry-2156
> https://issues.apache.org/jira/browse/sentry-2156
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add functions related to grant/revoke privileges to/from user
>
> Fix the bugs related to grant/revoke partial privileges. They are caused by
> adding fine grained privileges (CRATE, DROP, ALTER)
> add test cases for grant/revoke privileges to/from user
>
>
> Diffs
> -----
>
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java
> 71e9585
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
> 816cfe1
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java
> 8a77fc1
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
> cafe2b5
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
> 0322cc3
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java
> 3e31852
>
>
> Diff: https://reviews.apache.org/r/67174/diff/4/
>
>
> Testing
> -------
>
> all test cases in TestSentryStore passed
>
>
> Thanks,
>
> Na Li
>
>
