> On May 17, 2018, 10:22 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 172-173 (original), 176-178 (patched) > > <https://reviews.apache.org/r/67174/diff/2/?file=2024614#file2024614line177> > > > > Have we decided what the decomposition of the ALL when revoking > > individual actions be? I think we should not fix this issue yet. I thing > > the discussion is that we won't be able to decompose the ALL to avoid > > incompatibilities. > > Na Li wrote: > This code change is not to change behavior, but to fix the bugs in > existing behavior. If we decide to change the behavior, and not decompose the > ALL, we need to have another jira, and not change the behavior in this jira.
I changed the code, not the partial revoke behaves the same as before > On May 17, 2018, 10:22 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 785-793 (original) > > <https://reviews.apache.org/r/67174/diff/2/?file=2024614#file2024614line946> > > > > I think we should not fix yet. We're still in the decision whether to > > support decomposing the ALL privilege or just not allow it. There are > > incompatibilities when decompose it, so we just think it better before > > fixing it. the code is changed to keep old behavior for partial revoke - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203371 ----------------------------------------------------------- On May 21, 2018, 10:22 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67174/ > ----------------------------------------------------------- > > (Updated May 21, 2018, 10:22 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Bugs: sentry-2156 > https://issues.apache.org/jira/browse/sentry-2156 > > > Repository: sentry > > > Description > ------- > > Add functions related to grant/revoke privileges to/from user > > Fix the bugs related to grant/revoke partial privileges. They are caused by > adding fine grained privileges (CRATE, DROP, ALTER) > add test cases for grant/revoke privileges to/from user > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > 71e9585 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 816cfe1 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java > 8a77fc1 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 56c506b > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 0322cc3 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > 3e31852 > > > Diff: https://reviews.apache.org/r/67174/diff/5/ > > > Testing > ------- > > all test cases in TestSentryStore passed > > > Thanks, > > Na Li > >
