> On May 31, 2018, 7:10 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 1055-1057 (patched) > > <https://reviews.apache.org/r/67400/diff/1/?file=2033273#file2033273line1055> > > > > Can we move this logic to TSentryPrivilege that that this check is done > > on remoteRole, remoteUser?
no. In some situations, removing role does not persist the privilege right away. when dropping role, dropSentryRoleCore -> removePrivileges -> removeStaledPrivileges in bulk. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67400/#review204136 ----------------------------------------------------------- On May 31, 2018, 2:57 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67400/ > ----------------------------------------------------------- > > (Updated May 31, 2018, 2:57 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. > > > Bugs: sentry-2245 > https://issues.apache.org/jira/browse/sentry-2245 > > > Repository: sentry > > > Description > ------- > > Delete privilege when it is not associated with user nor role > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 5932335 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > e2d24e5 > > > Diff: https://reviews.apache.org/r/67400/diff/1/ > > > Testing > ------- > > TestSentryStore passed with added case to check number of privileges left > > > Thanks, > > Na Li > >
