> On June 5, 2018, 2:03 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 1401 (patched) > > <https://reviews.apache.org/r/67400/diff/2/?file=2034811#file2034811line1405> > > > > Will there be case where deleteIfStale can be false?
It is possible for owner privilege if admin removes owner from a table, and has not assign the new owner. We don't need to remove the owner privilege and then create it again. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67400/#review204317 ----------------------------------------------------------- On June 4, 2018, 1:49 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67400/ > ----------------------------------------------------------- > > (Updated June 4, 2018, 1:49 a.m.) > > > Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. > > > Bugs: sentry-2245 > https://issues.apache.org/jira/browse/sentry-2245 > > > Repository: sentry > > > Description > ------- > > Delete privilege when it is not associated with user nor role > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 5932335 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > e2d24e5 > > > Diff: https://reviews.apache.org/r/67400/diff/2/ > > > Testing > ------- > > TestSentryStore passed with added case to check number of privileges left > > > Thanks, > > Na Li > >
