----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67879/#review205969 -----------------------------------------------------------
I'm not done with my review yet. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java Line 415 (original), 416-417 (patched) <https://reviews.apache.org/r/67879/#comment288909> Suggestion on the message "Creating full snapshot is complete". To be consistent we should be logging snapshotInfo.getId() as well. - kalyan kumar kalvagadda On July 10, 2018, 9:54 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67879/ > ----------------------------------------------------------- > > (Updated July 10, 2018, 9:54 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > Adding to std.out will allow full snapshot timeline messages like has fetch > started, or has fetch been persisted, to be separated out from the rest of > the logs and be identified more easily > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 065adb74f > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java > 7667c47d5 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java > 9d1a92f18 > > > Diff: https://reviews.apache.org/r/67879/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
