----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67879/#review206044 -----------------------------------------------------------
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java Lines 99-100 (original), 100-103 (patched) <https://reviews.apache.org/r/67879/#comment289003> Along this change we need to log the reason why full update is sent to Namenode in the console. Otherwise person looking at it should go back to the logs to understand it. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java Line 415 (original), 417-419 (patched) <https://reviews.apache.org/r/67879/#comment289004> Suggestion on the message "Creating full snapshot is complete". You log says snapshot id but you are passing snapshotInfo. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java Line 236 (original), 237 (patched) <https://reviews.apache.org/r/67879/#comment289006> Don't you think reson for triggering full update should be logged in console? - kalyan kumar kalvagadda On July 11, 2018, 6:25 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67879/ > ----------------------------------------------------------- > > (Updated July 11, 2018, 6:25 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2309 > https://issues.apache.org/jira/browse/SENTRY-2309 > > > Repository: sentry > > > Description > ------- > > Adding to std.out will allow full snapshot timeline messages like has fetch > started, or has fetch been persisted, to be separated out from the rest of > the logs and be identified more easily > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 065adb74f > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/common/SentryServiceUtil.java > 719e616bf > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java > 7667c47d5 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java > 9d1a92f18 > > > Diff: https://reviews.apache.org/r/67879/diff/4/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
