> On Aug. 22, 2018, 5:37 p.m., kalyan kumar kalvagadda wrote: > > Arjun, > > > > I see you added fetching groups in a lot of API's. Do we know if there wil > > be performence benifit in all the cases to to have fetch plan and avoid > > loose fetching?
I have worked with Arjun yesterday on the behavior of default fetch group. So far, it seems when there are more than 2 fields specifies "default-fetch-group="true"", only the first two fields are bulk-fetched automatically. The other fields are fetched on demand, and cause performance issue. We will work more to confirm this behavior. If it is true, then it is safer to specify fetching group to make sure those fields are fetched in bulk as it does not cause cause harm, but to guarantee good performance. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61863/#review207758 ----------------------------------------------------------- On Aug. 21, 2018, 7:19 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61863/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2018, 7:19 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > Right now when we get privileges from sentry, we pass in a provider like set > of groups. Then we create a MSentryGroup object for each group and then get > roles using the .getRoles() method. This is bad since we only need the > roleNames for the group and not the entire Role object. > Instead running a SQL like query and just getting roleNames will drastically > improve performance > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 0ef6a208f > > > Diff: https://reviews.apache.org/r/61863/diff/4/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
