----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61863/ -----------------------------------------------------------
(Updated Aug. 21, 2018, 7:19 p.m.) Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. Summary (updated) ----------------- SENTRY-1896 - Optimize retrieving entities by other entity types Repository: sentry Description ------- Right now when we get privileges from sentry, we pass in a provider like set of groups. Then we create a MSentryGroup object for each group and then get roles using the .getRoles() method. This is bad since we only need the roleNames for the group and not the entire Role object. Instead running a SQL like query and just getting roleNames will drastically improve performance Diffs ----- sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 0ef6a208f Diff: https://reviews.apache.org/r/61863/diff/4/ Testing ------- Thanks, Arjun Mishra