> On Aug. 23, 2018, 1:48 p.m., Na Li wrote: > > sentry-dist/src/license/THIRD-PARTY.properties > > Line 32 (original), 32 (patched) > > <https://reviews.apache.org/r/68488/diff/1/?file=2076572#file2076572line32> > > > > do we need to commit this file?
Nope didnt mean to, will pull from patch - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review207825 ----------------------------------------------------------- On Aug. 23, 2018, 11:41 a.m., Brian Towles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68488/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2018, 11:41 a.m.) > > > Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na > Li, Steve Moist, and Sergio Pena. > > > Bugs: SENTRY-2367 > https://issues.apache.org/jira/browse/SENTRY-2367 > > > Repository: sentry > > > Description > ------- > > Basic implementation of the Java SPI. Abstracted to provide Factory > configuration for > instances of Service defined. > > Currently stand alone module. Will be built used by ABCM in future commits. > > > Diffs > ----- > > lombok.config PRE-CREATION > pom.xml dcf107680c3b395819043136bcc6e179a60ada35 > sentry-dist/src/license/THIRD-PARTY.properties > a1084db6962cefb2a710cc3871de6c1c083892ce > sentry-spi/pom.xml PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java > PRE-CREATION > > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java > PRE-CREATION > > sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory > PRE-CREATION > sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68488/diff/1/ > > > Testing > ------- > > Unit tests. > > > Thanks, > > Brian Towles > >
