----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review207847 -----------------------------------------------------------
sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java Lines 27 (patched) <https://reviews.apache.org/r/68488/#comment291380> What is this file - where does it come from? sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java Lines 23 (patched) <https://reviews.apache.org/r/68488/#comment291381> Where does this file come from? sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java Lines 25 (patched) <https://reviews.apache.org/r/68488/#comment291382> where ddoes this file come from? sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java Lines 34 (patched) <https://reviews.apache.org/r/68488/#comment291383> Typo? "Provider manager *what*" sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java Lines 24 (patched) <https://reviews.apache.org/r/68488/#comment291384> Is this file coming from somewhere? - Alexander Kolbasov On Aug. 24, 2018, 1:15 a.m., Brian Towles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68488/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2018, 1:15 a.m.) > > > Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na > Li, Steve Moist, and Sergio Pena. > > > Bugs: SENTRY-2367 > https://issues.apache.org/jira/browse/SENTRY-2367 > > > Repository: sentry > > > Description > ------- > > Basic implementation of the Java SPI. Abstracted to provide Factory > configuration for > instances of Service defined. > > Currently stand alone module. Will be built used by MDCM in future commits. > > > Diffs > ----- > > lombok.config PRE-CREATION > pom.xml dcf107680c3b395819043136bcc6e179a60ada35 > sentry-spi/pom.xml PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java > PRE-CREATION > > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java > PRE-CREATION > > sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory > PRE-CREATION > sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68488/diff/2/ > > > Testing > ------- > > Unit tests. > > > Thanks, > > Brian Towles > >
