> On Aug. 28, 2018, 8:07 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > > Lines 67 (patched) > > <https://reviews.apache.org/r/68547/diff/1/?file=2078642#file2078642line67> > > > > This is wrong. > > ImageID is for fullsnapshot, Within the same full snapshot, there is > > changID for each path change. You have to check the max changID in the > > cached update to make sure there is no new change.
Yep. My bad - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/#review208061 ----------------------------------------------------------- On Aug. 28, 2018, 7:08 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68547/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2018, 7:08 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2370 > https://issues.apache.org/jira/browse/SENTRY-2370 > > > Repository: sentry > > > Description > ------- > > When NN requests path updates from sentry and if it exceeds the time > threshold, on consecutive attempts sentry will attempt to fetch the full > update from scratch. Instead it should cache it and update the cache before > sending it to NN > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > 2b1618134 > > > Diff: https://reviews.apache.org/r/68547/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
