> On Aug. 29, 2018, 1:28 p.m., kalyan kumar kalvagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > > Line 52 (original), 54 (patched) > > <https://reviews.apache.org/r/68547/diff/1/?file=2078642#file2078642line54> > > > > This condition is not correct. When cachePathsUpdate is not null it > > will always return cachePathsUpdate. cachePathsUpdate will never be updated.
I caught that. It will be in the new patch - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/#review208090 ----------------------------------------------------------- On Aug. 28, 2018, 7:08 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68547/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2018, 7:08 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2370 > https://issues.apache.org/jira/browse/SENTRY-2370 > > > Repository: sentry > > > Description > ------- > > When NN requests path updates from sentry and if it exceeds the time > threshold, on consecutive attempts sentry will attempt to fetch the full > update from scratch. Instead it should cache it and update the cache before > sending it to NN > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > 2b1618134 > > > Diff: https://reviews.apache.org/r/68547/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >