> On Aug. 29, 2018, 3:29 p.m., Steve Moist wrote: > > lombok.config > > Lines 1 (patched) > > <https://reviews.apache.org/r/68488/diff/2/?file=2076862#file2076862line1> > > > > In introducing lombok into sentry. Will the configs for the existing > > sl4j need to be updated or modified? > > > > I would recommend that we move this lombok change into a seperate > > changeset. I would want all of Sentry to be consistant with it's logging > > mechanism. > > Alexander Kolbasov wrote: > Agreed - it is always better not to mix two independent changes together.
This doesnt change anything to do with the logs or logging. This is simply the name of the variable that lombok creates when it sets up the static logger instance in the class annotated with @Slf4j. - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review208112 ----------------------------------------------------------- On Aug. 23, 2018, 8:15 p.m., Brian Towles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68488/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2018, 8:15 p.m.) > > > Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na > Li, Steve Moist, and Sergio Pena. > > > Bugs: SENTRY-2367 > https://issues.apache.org/jira/browse/SENTRY-2367 > > > Repository: sentry > > > Description > ------- > > Basic implementation of the Java SPI. Abstracted to provide Factory > configuration for > instances of Service defined. > > Currently stand alone module. Will be built used by MDCM in future commits. > > > Diffs > ----- > > lombok.config PRE-CREATION > pom.xml dcf107680c3b395819043136bcc6e179a60ada35 > sentry-spi/pom.xml PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java > PRE-CREATION > > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java > PRE-CREATION > > sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory > PRE-CREATION > sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68488/diff/2/ > > > Testing > ------- > > Unit tests. > > > Thanks, > > Brian Towles > >
