----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/#review208573 -----------------------------------------------------------
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java Lines 137 (patched) <https://reviews.apache.org/r/68547/#comment292628> This condition can be changed to if(invalidateCacheOnSendingDeltas && imageCache.hasCache()) as long as imageCache has cache, we should invalidate it. It has nothing to do with if the cache is current or not. sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathsUpdateImageCache.java Lines 24 (patched) <https://reviews.apache.org/r/68547/#comment292624> this should be PathsUpdateImageCache implements ImageCache<PathsUpdate> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathsUpdateImageCache.java Lines 56 (patched) <https://reviews.apache.org/r/68547/#comment292625> this should be if(pathsUpdateImageCache.getSeqNum() < sequenceNum) When system starts, NN will ask with sequenceNum = 0, and full snapshot will have pathsUpdateImageCache.getSeqNum() >= 0. Have you tested that the cache mechanism does work as expected? Will isImageCurrent() always return false even when cache is up-to-date? sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermissionsUpdateImageCache.java Lines 24 (patched) <https://reviews.apache.org/r/68547/#comment292626> same problem sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermissionsUpdateImageCache.java Lines 50 (patched) <https://reviews.apache.org/r/68547/#comment292627> same issue - Na Li On Sept. 12, 2018, 6:41 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68547/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2018, 6:41 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2370 > https://issues.apache.org/jira/browse/SENTRY-2370 > > > Repository: sentry > > > Description > ------- > > When NN requests path updates from sentry and if it exceeds the time > threshold, on consecutive attempts sentry will attempt to fetch the full > update from scratch. Instead it should cache it and update the cache before > sending it to NN > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ImageCache.java > PRE-CREATION > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java > 2d21411e2 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 08b16a4df > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathsUpdateImageCache.java > PRE-CREATION > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermissionsUpdateImageCache.java > PRE-CREATION > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java > b8f5ce7db > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > f86ce6f83 > > > Diff: https://reviews.apache.org/r/68547/diff/5/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
