> On Oct. 19, 2018, 7:56 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java > > Lines 127 (patched) > > <https://reviews.apache.org/r/69076/diff/2/?file=2100075#file2100075line127> > > > > We already have a timer for this purpose, name > > "org.apache.sentry.service.thrift.FullUpdateInitializer.snapshot" > > > > It is defined in SentryHMSClient > > private final Timer updateTimer = SentryMetrics.getInstance() > > .getTimer(name(FullUpdateInitializer.class, SNAPSHOT)); > > > > It is called in > > SentryHMSClient.fetchFullUpdate() > > > > Do we need another timer for the same purpose?
The existing timer is removed to be the timer specified here. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69076/#review209799 ----------------------------------------------------------- On Oct. 18, 2018, 9:29 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69076/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2018, 9:29 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > When sentry is fetching snapshot from HMS, it should log periodically on > where it stands in the snapshot process. This will help person debugging it > and help him understand the progress. > > > > This is important as this process could take magnitude of minutes when the > HMS data is huge. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java > 214d78c53 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java > 3e27d1bbe > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java > 4baeb6725 > > > Diff: https://reviews.apache.org/r/69076/diff/2/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
