----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69076/#review212599 -----------------------------------------------------------
Ship it! Ship It! - Na Li On Jan. 29, 2019, 9:09 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69076/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2019, 9:09 p.m.) > > > Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and > Sergio Pena. > > > Bugs: SENTRY-2301 > https://issues.apache.org/jira/browse/SENTRY-2301 > > > Repository: sentry > > > Description > ------- > > When sentry is fetching snapshot from HMS, it should log periodically on > where it stands in the snapshot process. This will help person debugging it > and help him understand the progress. > > > > This is important as this process could take magnitude of minutes when the > HMS data is huge. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java > 2d21411e2 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java > 534bb51c1 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java > 4ff3dc91a > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java > 4baeb6725 > > > Diff: https://reviews.apache.org/r/69076/diff/6/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >