> On Sept. 28, 2018, 4:56 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java > > Lines 136-137 (patched) > > <https://reviews.apache.org/r/68547/diff/6/?file=2092473#file2092473line136> > > > > Why is the cache needed to be instantiated and passed as aparameter > > instead of instatiating the cache inside the PathImageRetriever and > > PermImageRetriever instead? > > > > A retriever returns the paths, but if they're cache, then it returns > > the ones from the cache. > > Arjun Mishra wrote: > Sergio we haev 2 path classes PathImageRetriever, PathDeltaRetriever. > Even though we need cache to be in PathImageRetriever, we need the cache to > be visible to PathDeltaRetriever so it can be invalidated. > > Sergio Pena wrote: > Is a cache needed for deltas as well? I think the cache should be handled > internally on each retriever.
Yes but that is a different ticket - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/#review209098 ----------------------------------------------------------- On Oct. 5, 2018, 7:11 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68547/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2018, 7:11 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2370 > https://issues.apache.org/jira/browse/SENTRY-2370 > > > Repository: sentry > > > Description > ------- > > When NN requests path updates from sentry and if it exceeds the time > threshold, on consecutive attempts sentry will attempt to fetch the full > update from scratch. Instead it should cache it and update the cache before > sending it to NN > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 08b16a4df > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > f86ce6f83 > > > Diff: https://reviews.apache.org/r/68547/diff/11/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >