> On Oct. 8, 2018, 4:18 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 222 (patched) > > <https://reviews.apache.org/r/68547/diff/11/?file=2094968#file2094968line222> > > > > Just check if they're different. It is a simple case. A cache is not > > more valid if the seq num is different (higher or lower, it does not > > matter). This logic is assumming HDFS will never request a lower value. We > > should not assume that.
cache.seqNum needs to be strictly less than for it to request a fresh full update. If cache.seqNum is greater than requestedSeqNum, we can simply return that cache and the subsequent request NN will ask for deltas greater than cache.seqNum so it will be able to catch up. If that sequence number doesn't not exist, we will do a fresh fetch from Sentry db - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/#review209315 ----------------------------------------------------------- On Oct. 5, 2018, 7:11 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68547/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2018, 7:11 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2370 > https://issues.apache.org/jira/browse/SENTRY-2370 > > > Repository: sentry > > > Description > ------- > > When NN requests path updates from sentry and if it exceeds the time > threshold, on consecutive attempts sentry will attempt to fetch the full > update from scratch. Instead it should cache it and update the cache before > sending it to NN > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 08b16a4df > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > f86ce6f83 > > > Diff: https://reviews.apache.org/r/68547/diff/11/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
