----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36832/#review93086 -----------------------------------------------------------
Most of the code look good, a few of comments below. Please let me know if you have any question? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/HiveAuditMetadataLogEntity.java (line 29) <https://reviews.apache.org/r/36832/#comment147346> I think Impala may also use **HiveAuditMetadataLogEntity**, Do you think **DbAuditMetadataLogEntity** is more suitable? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/HiveAuditMetadataLogEntity.java (line 37) <https://reviews.apache.org/r/36832/#comment147344> Is there any place need constructor without field? if not, we may need to delete it or mark it private sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/HiveAuditMetadataLogEntity.java (line 109) <https://reviews.apache.org/r/36832/#comment147347> If we return the new StringWriter, will the audit log still work? If not, we may need to throw the exception. - Dapeng Sun On 七月 27, 2015, 11:09 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36832/ > ----------------------------------------------------------- > > (Updated 七月 27, 2015, 11:09 a.m.) > > > Review request for sentry, Dapeng Sun and shen guoquan. > > > Repository: sentry > > > Description > ------- > > Refactor the AuditMetadataLogEntity to support the audit log for generic mdoel > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java > 6b63045 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/HiveAuditMetadataLogEntity.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestAuditMetadataLogEntity.java > 95b51e9 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestHiveAuditMetadataLogEntity.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36832/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
