----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36832/#review95825 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestHiveAuditMetadataLogEntity.java (line 29) <https://reviews.apache.org/r/36832/#comment150969> This class name should be **TestDBAuditMetadataLogEntity** Most looks good to me, one minor comment left - Dapeng Sun On 八月 13, 2015, 1:11 p.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36832/ > ----------------------------------------------------------- > > (Updated 八月 13, 2015, 1:11 p.m.) > > > Review request for sentry, Dapeng Sun and shen guoquan. > > > Repository: sentry > > > Description > ------- > > Refactor the AuditMetadataLogEntity to support the audit log for generic mdoel > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java > 6b63045 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestAuditMetadataLogEntity.java > 95b51e9 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestHiveAuditMetadataLogEntity.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36832/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
