----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36833/#review93098 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java (line 34) <https://reviews.apache.org/r/36833/#comment147354> We may don't need to initialize a LinkedHashMap here. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java (line 36) <https://reviews.apache.org/r/36833/#comment147352> same question: Is there any place need the constructor without field? if not, we may need to delete it or mark it private sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java (line 74) <https://reviews.apache.org/r/36833/#comment147353> same question: If we return the new StringWriter, will the audit log still work? If not, we may need to throw the exception. - Dapeng Sun On 七月 27, 2015, 11:15 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36833/ > ----------------------------------------------------------- > > (Updated 七月 27, 2015, 11:15 a.m.) > > > Review request for sentry, Dapeng Sun and shen guoquan. > > > Repository: sentry > > > Description > ------- > > Add new log entity for generic model > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestGMAuditMetadataLogEntity.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36833/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
