> On July 27, 2015, 7:59 a.m., Dapeng Sun wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java, > > line 36 > > <https://reviews.apache.org/r/36833/diff/1/?file=1022153#file1022153line36> > > > > same question: Is there any place need the constructor without field? > > if not, we may need to delete it or mark it private
Yes, this constructor is necessary for the core function and test case. > On July 27, 2015, 7:59 a.m., Dapeng Sun wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java, > > line 74 > > <https://reviews.apache.org/r/36833/diff/1/?file=1022153#file1022153line74> > > > > same question: If we return the new StringWriter, will the audit log > > still work? If not, we may need to throw the exception. thanks, you can get the comments on https://reviews.apache.org/r/36832/ > On July 27, 2015, 7:59 a.m., Dapeng Sun wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java, > > line 34 > > <https://reviews.apache.org/r/36833/diff/1/?file=1022153#file1022153line34> > > > > We may don't need to initialize a LinkedHashMap here. thanks, I'll remove the initialize. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36833/#review93098 ----------------------------------------------------------- On July 28, 2015, 1:19 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36833/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 1:19 a.m.) > > > Review request for sentry, Dapeng Sun and shen guoquan. > > > Repository: sentry > > > Description > ------- > > Add new log entity for generic model > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestGMAuditMetadataLogEntity.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36833/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
