----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36834/#review94689 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java (line 149) <https://reviews.apache.org/r/36834/#comment149299> Could we use short class name here? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java (line 155) <https://reviews.apache.org/r/36834/#comment149300> Same above: could we use short class name here? I found many places use long class names. - Dapeng Sun On 七月 27, 2015, 11:18 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36834/ > ----------------------------------------------------------- > > (Updated 七月 27, 2015, 11:18 a.m.) > > > Review request for sentry, Dapeng Sun and shen guoquan. > > > Repository: sentry > > > Description > ------- > > Update the util to generate the command for audit log > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java > 741cfdc > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java > 072a0e8 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java > 0a2b0b2 > > Diff: https://reviews.apache.org/r/36834/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
