> On 八月 10, 2015, 9:10 a.m., Dapeng Sun wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java, > > line 170 > > <https://reviews.apache.org/r/36834/diff/1/?file=1022155#file1022155line170> > > > > Same above: could we use short class name here? I found many places use > > long class names. > > Colin Ma wrote: > Unfortunately, I have to use long class names here, because > TAlterSentryRoleRevokePrivilegeRequest has the same class name but different > package name for hive model and generic model. > The util class need include both class, one of them has to be with long > class name.
Okay, I see. @Guoquan, do you think we can change the classname of Generic model? - Dapeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36834/#review94689 ----------------------------------------------------------- On 八月 13, 2015, 1:07 p.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36834/ > ----------------------------------------------------------- > > (Updated 八月 13, 2015, 1:07 p.m.) > > > Review request for sentry, Dapeng Sun and shen guoquan. > > > Repository: sentry > > > Description > ------- > > Update the util to generate the command for audit log > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java > 741cfdc > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java > 072a0e8 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java > 0a2b0b2 > > Diff: https://reviews.apache.org/r/36834/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
