----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43704/#review120085 -----------------------------------------------------------
Thank Colin, I left some comments. sentry-policy/pom.xml (line 34) <https://reviews.apache.org/r/43704/#comment181453> do we need a new module? can we put them into common? sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DatabaseRequiredInPrivilege.java (line 50) <https://reviews.apache.org/r/43704/#comment181451> It seems the property is related to database model, why we put it to PolicyConstant? sentry-policy/sentry-policy-engine/pom.xml (line 37) <https://reviews.apache.org/r/43704/#comment181452> Why we need hadoop common and minicluster dependencies? - Dapeng Sun On 二月 18, 2016, 9:37 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43704/ > ----------------------------------------------------------- > > (Updated 二月 18, 2016, 9:37 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Create CommonPolicy for external component > > > Diffs > ----- > > sentry-policy/pom.xml ef938a6 > > sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/PolicyConstants.java > 8e4d465 > > sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DatabaseRequiredInPrivilege.java > e89aa16 > sentry-policy/sentry-policy-engine/pom.xml PRE-CREATION > > sentry-policy/sentry-policy-engine/src/main/java/org/apache/sentry/policy/engine/common/CommonPolicyEngine.java > PRE-CREATION > > sentry-policy/sentry-policy-engine/src/main/java/org/apache/sentry/policy/engine/common/CommonPrivilegeFactory.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java > 985f969 > > Diff: https://reviews.apache.org/r/43704/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
