> On 二月 22, 2016, 9:45 a.m., Dapeng Sun wrote: > > sentry-policy/pom.xml, line 34 > > <https://reviews.apache.org/r/43704/diff/2/?file=1253500#file1253500line34> > > > > do we need a new module? can we put them into common? > > Colin Ma wrote: > For sentry-policy-common, it is a dependency of sentry-provider-common, > and CommonPolicy should depend on sentry-provider-common. If using the > sentry-policy-common, there will be a circle denpendency problem. > In the other hand, both AuthorizationProvider and ProviderBackend in > sentry-provider-common is not reasonable. They should be seperated.
SGTM - Dapeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43704/#review120085 ----------------------------------------------------------- On 二月 22, 2016, 11:13 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43704/ > ----------------------------------------------------------- > > (Updated 二月 22, 2016, 11:13 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Create CommonPolicy for external component > > > Diffs > ----- > > sentry-policy/pom.xml ef938a6 > sentry-policy/sentry-policy-engine/pom.xml PRE-CREATION > > sentry-policy/sentry-policy-engine/src/main/java/org/apache/sentry/policy/engine/common/CommonPolicyEngine.java > PRE-CREATION > > sentry-policy/sentry-policy-engine/src/main/java/org/apache/sentry/policy/engine/common/CommonPrivilegeFactory.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/43704/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
