> On Feb. 26, 2016, 10:41 p.m., Anne Yu wrote: > >
Anne, thanks for the review. > On Feb. 26, 2016, 10:41 p.m., Anne Yu wrote: > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java, > > line 347 > > <https://reviews.apache.org/r/43977/diff/1/?file=1270512#file1270512line347> > > > > Wondering if these lines are still needed? If so, why comment them out? Removed in SENTRY-1057. > On Feb. 26, 2016, 10:41 p.m., Anne Yu wrote: > > sentry-policy/sentry-policy-kafka/src/test/java/org/apache/sentry/policy/kafka/TestKafkaModelAuthorizables.java, > > line 63 > > <https://reviews.apache.org/r/43977/diff/1/?file=1270520#file1270520line63> > > > > Does this change mean for cluster name, can't be case-insensitive? No, it can't. It is discussed more on SENTRY-1030. > On Feb. 26, 2016, 10:41 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/TestAclsCrud.java, > > line 17 > > <https://reviews.apache.org/r/43977/diff/1/?file=1270532#file1270532line17> > > > > High level question: can these e2e tests be run on a real cluster? > > sentry dbProvider tests can run both locally and on a real cluster. If > > these kafka tests can also be run for real, we can effectively test > > generical model + clients, even server/client compatibility. Not sure. I have not tried that, I think it should be doable with a few tweaks. However, this JIRA is not going to address that issue. If required, we will file a separate JIRA to track that. > On Feb. 26, 2016, 10:41 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/TestAclsCrud.java, > > line 134 > > <https://reviews.apache.org/r/43977/diff/1/?file=1270532#file1270532line134> > > > > Wondering why catch then rethrow? For better error message. Also, I think that it makes the test readable. > On Feb. 26, 2016, 10:41 p.m., Anne Yu wrote: > > sentry-core/sentry-core-model-kafka/src/test/java/org/apache/sentry/core/model/kafka/TestKafkaAuthorizable.java, > > line 17 > > <https://reviews.apache.org/r/43977/diff/1/?file=1270518#file1270518line17> > > > > High level design question: could these kafka tests be run parallelly > > (on class level)? We want to reduce unit tests running time. Good question, have not tested it, but should be doable. We should file a separate JIRA if we want to track that. Moreover, those tests are not part of this JIRA. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43977/#review120974 ----------------------------------------------------------- On Feb. 25, 2016, 1:53 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43977/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 1:53 a.m.) > > > Review request for sentry, Dapeng Sun and Hao Hao. > > > Bugs: SENTRY-1014 > https://issues.apache.org/jira/browse/SENTRY-1014 > > > Repository: sentry > > > Description > ------- > > SENTRY-1014: Add E2E tests for Kafka plugin. > > > Diffs > ----- > > pom.xml ca2c92a26e3e42fe036c974235db47255d1465de > sentry-binding/sentry-binding-kafka/pom.xml > bd24c20edcbffb5caee69aedddb93cb5a6c8c112 > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java > 9ffb971d8da51b716ece3ff5a5bbeebcc7f74e8d > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java > 9e72d7890e0db3710ab0971ccbb71a32d3d36e87 > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java > 92e50e6452a89e676eb559a3657b17ba563bfddc > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java > e75ec7eddaa1a48b731d551736859a94c08af593 > > sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java > eafe0f0ee5482fadee43ddec99bdc5da3f42e30f > > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/Cluster.java > bb30b1b78d4dccaf8ea5fe22eeed496b608cfcb1 > > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaActionFactory.java > 7b8b5187e3d95a49304512e238e778da885fd27d > > sentry-core/sentry-core-model-kafka/src/test/java/org/apache/sentry/core/model/kafka/TestKafkaAuthorizable.java > 20d5e8e518cb91b32fad930e9d39400764f40b55 > > sentry-policy/sentry-policy-kafka/src/main/java/org/apache/sentry/policy/kafka/KafkaModelAuthorizables.java > f1ed0001883e5d4b362389c258f4f72697a1e5a4 > > sentry-policy/sentry-policy-kafka/src/test/java/org/apache/sentry/policy/kafka/TestKafkaModelAuthorizables.java > 513c2719424f994e8eb773e72073401b465b7d58 > > sentry-policy/sentry-policy-kafka/src/test/java/org/apache/sentry/policy/kafka/provider/TestKafkaAuthorizationProviderGeneralCases.java > bcc119860860d928d092ed3ddc0a5a28e841c9aa > sentry-provider/sentry-provider-db/pom.xml > 7514a7cdfcc7934f2dd0386996fdaf88c0ccbb14 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java > c3b0be8694c746cb09797425f98578b8faef8b4a > sentry-tests/pom.xml 3294335e95fb7dbb2da4151041269392004426fb > sentry-tests/sentry-tests-kafka/pom.xml PRE-CREATION > > sentry-tests/sentry-tests-kafka/src/main/java/org/apache/sentry/tests/e2e/kafka/CustomPrincipalBuilder.java > PRE-CREATION > > sentry-tests/sentry-tests-kafka/src/main/java/org/apache/sentry/tests/e2e/kafka/EmbeddedZkServer.java > PRE-CREATION > > sentry-tests/sentry-tests-kafka/src/main/java/org/apache/sentry/tests/e2e/kafka/KafkaTestServer.java > PRE-CREATION > > sentry-tests/sentry-tests-kafka/src/main/java/org/apache/sentry/tests/e2e/kafka/TestUtils.java > PRE-CREATION > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java > PRE-CREATION > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/StaticUserGroupRole.java > PRE-CREATION > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/TestAclsCrud.java > PRE-CREATION > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/TestAuthorize.java > PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/log4j.properties > PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/test.crt PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/test.keystore.jks > PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/test.truststore.jks > PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/user1.crt PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/user1.keystore.jks > PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/user1.truststore.jks > PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/user2.crt PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/user2.keystore.jks > PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/user2.truststore.jks > PRE-CREATION > > Diff: https://reviews.apache.org/r/43977/diff/ > > > Testing > ------- > > Added E2E tests. > > Note that this contains changes from SENTRY-1098, SENTRY-1056, SENTRY-1030 > and SENTRY-1057, and will have to be rebased once they get it. > > > Thanks, > > Ashish Singh > >
