> On March 8, 2016, 2 a.m., Hao Hao wrote: > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/TestAuthorize.java, > > line 58 > > <https://reviews.apache.org/r/43977/diff/3/?file=1287043#file1287043line58> > > > > Should it be 'admin' instead of 'test' to be more accurate?
This will require changing the generated keystore and truststore files to just rename it. I have used a variable `final String SuperuserName = "test";` too allevaite your concern. Hope it is OK with you. > On March 8, 2016, 2 a.m., Hao Hao wrote: > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/TestAuthorize.java, > > line 102 > > <https://reviews.apache.org/r/43977/diff/3/?file=1287043#file1287043line102> > > > > "create topic" instead of "describe topic"? Added more info. > On March 8, 2016, 2 a.m., Hao Hao wrote: > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/TestAuthorize.java, > > line 111 > > <https://reviews.apache.org/r/43977/diff/3/?file=1287043#file1287043line111> > > > > A little confused here. Isn't addPermission grant the needed permission > > there? Here user is trying to produce/write to a topic. So, the user should have write/produce permissions on the topic. Did I answer your question? - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43977/#review122434 ----------------------------------------------------------- On March 8, 2016, 12:23 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43977/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 12:23 a.m.) > > > Review request for sentry, Anne Yu, Dapeng Sun, and Hao Hao. > > > Bugs: SENTRY-1014 > https://issues.apache.org/jira/browse/SENTRY-1014 > > > Repository: sentry > > > Description > ------- > > SENTRY-1014: Add E2E tests for Kafka plugin. > > > Diffs > ----- > > > sentry-tests/sentry-tests-kafka/src/main/java/org/apache/sentry/tests/e2e/kafka/KafkaTestServer.java > 129191ae6f9fa4cc6794117fddb693a3cd1ab815 > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/TestAuthorize.java > PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/user1.keystore.jks > PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/user1.truststore.jks > PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/user2.keystore.jks > PRE-CREATION > sentry-tests/sentry-tests-kafka/src/test/resources/user2.truststore.jks > PRE-CREATION > > Diff: https://reviews.apache.org/r/43977/diff/ > > > Testing > ------- > > Added E2E tests. > > Note that this contains changes from SENTRY-1098, SENTRY-1056, SENTRY-1030 > and SENTRY-1057, and will have to be rebased once they get it. > > > Thanks, > > Ashish Singh > >
