brainy commented on code in PR #9:
URL: https://github.com/apache/serf/pull/9#discussion_r2177285382
##########
buckets/ssl_buckets.c:
##########
@@ -1788,6 +1821,9 @@ static serf_ssl_context_t
*ssl_init_context(serf_bucket_alloc_t *allocator)
ssl_ctx->protocol_callback = NULL;
ssl_ctx->protocol_userdata = NULL;
+ ssl_ctx->error_callback = NULL;
+ ssl_ctx->error_userdata = NULL;
Review Comment:
We call those batons, so: `error_baton`. Hmph, should do the same for
`protocol_userdata` ⟶ `protocol_baton`.
##########
serf_bucket_types.h:
##########
@@ -647,6 +647,22 @@ void serf_ssl_server_cert_chain_callback_set(
serf_ssl_server_cert_chain_cb_t cert_chain_callback,
void *data);
+/**
+ * Callback type for detailed TLS error strings.
+ */
+typedef apr_status_t (*serf_ssl_error_cb_t)(
+ void *data,
Review Comment:
Again: `void *baton`.
##########
serf_bucket_types.h:
##########
@@ -647,6 +647,22 @@ void serf_ssl_server_cert_chain_callback_set(
serf_ssl_server_cert_chain_cb_t cert_chain_callback,
void *data);
+/**
+ * Callback type for detailed TLS error strings.
+ */
+typedef apr_status_t (*serf_ssl_error_cb_t)(
+ void *data,
+ const char *message);
+
+/**
+ * Set a callback to return any detailed certificate error from the underlying
+ * cryptographic library..
+ */
+void serf_ssl_error_cb_set(
+ serf_ssl_context_t *context,
+ serf_ssl_error_cb_t callback,
+ void *data);
Review Comment:
And here, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@serf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
