minfrin commented on PR #9: URL: https://github.com/apache/serf/pull/9#issuecomment-3023598205
> Since this callback is on the context, it's serialised within the context run right? I assume that the idea is to store those messages at the caller and report them if `serf_context_run()` fails (or report them as warnings if it doesn't, I guess.) > > If that's the case, it would be nice to document that in a docstring in `serf_bucket_types.h`. Right now it's not at all obvious how that callback should be implemented. All of this is pretty much the caller's problem. The callback just fires every time there is an error, it's up to the caller to pass a baton that makes sense, and a callback routine that understands the baton. In existing subversion, the context run keeps going until an SSL error happens, and if an SSL error happens the whole context is shut down and the client gives up. In this case the callback fires first, and subversion (shortly) makes a copy of the message for later. When later comes, any error message from a callback is added to svn_error_t. Other applications could work completely differently, serf shouldn't care. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@serf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
