On 05 Jul 2025, at 11:05, Branko Čibej <br...@apache.org> wrote:

> Please use the log format we're accustomed to, and try to limit line lengths 
> to 80 columns. It's kind of a tradition here.
> 
> For log messages, we follow Subversion's guidelines:
> https://subversion.apache.org/docs/community-guide/conventions.html#log-messages

Does this work?

Add support for SSL error handling

[minfrin@rocky9 subversion]$ svn info https://svn.example.com/svn/example/core/ 
svn: E170013: Unable to connect to a repository at URL 
'https://svn.example.com/svn/example/core'
svn: E120170: TLS: error:0308010C:digital envelope routines::unsupported
svn: E120170: TLS: could not parse PKCS12: /home/minfrin/.my-cert.p12

* serf_bucket_types.h
  (serf_ssl_error_cb_set): Allow the registration of an optional callback to
  which error strings will be sent.

* buckets/ssl_buckets.c
  (serf_ssl_context_t): Add error_callback.
  (log_ssl_error): Trigger error callback.
  (status_from_ssl_error): Support SSL_ERROR_WANT_X509_LOOKUP. Client side SSL
  certificate errors now cause the client side to abort the connection.
  Previously no certificate was silently sent, and the error was access denied
  from the server.
  (ssl_need_client_cert): Trigger callback with error explanation, remove an
  infinite loop when the PKCS12 file cannot be opened.
  (serf_ssl_error_cb_set): New function.
  (ssl_new_session): Init the callback.

(I have updated the commit)

Regards,
Graham
--

Reply via email to